add North detection to Overworld watcher #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysticial
reviewed
Sep 18, 2024
| @@ -77,7 +88,7 @@ std::pair<double, double> DirectionDetector::locate_north(ConsoleHandle& console | |||
| if (zero_coord.first > 0.91 || zero_coord.first < 0.90 || | |||
| zero_coord.second > 0.84 || zero_coord.second < 0.82) | |||
| { | |||
| console.log("Unable to locate the overworld radar ball, falling back on hard coded location.", COLOR_ORANGE); | |||
| std::cout << "Unable to locate the overworld radar ball, falling back on hard coded location." << std::endl; | |||
There was a problem hiding this comment.
Stick with console.log() for normal logging and reserve std::cout only for debugging.
There was a problem hiding this comment.
If we use console in locate_north, it means that OverworldWatcher can no longer use it (via detect_north), since OverworldWatcher doesn't contain console.
So, I see 2 other options:
- Refactor OverworldWatcher to contain console in its constructor.
- Leave console within locate_north. But then copy its code into detect_north, and remove the sections that require console. This allows OverworldWatcher to still use detect_north. But this creates code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.