Improve performance of Material Detector #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jw098
commented
Jul 10, 2024
jw098
commented
- use Waterfill OCR instead of straight OCR. I tested it for number 1->999 for both white and black text.
- since we only need 1 thread for Waterfill OCR, I also parallelized detection of material value. I tested it on my old laptop, it runs well, and runs faster than before.
jw098
commented
Jul 10, 2024
| ); | ||
| // filtered.save("DebugDumps/test-one-filter-1.png"); | ||
| bool is_dark_text_light_background = image_stats(filtered).average.sum() > 500; |
There was a problem hiding this comment.
I'm not sure if this is the best way to check if the text is dark vs light. Happy to hear any suggestions.
There was a problem hiding this comment.
500 feels too high. IIRC, I've had issues detecting whites in the past with 500 on my "bad" capture card.
What are the actual values for dark vs. light? Maybe pick the mid-point?
There was a problem hiding this comment.
Dark text light background is usually >600. Light text dark background is usually <200.
I've changed it to 400.
Also, I do apply a binary filter first, so that should hopefully help as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.