BBQ Solo Farmer #407

kichithewolf · 2024-03-03T20:21:00Z

BBQ json: PokemonAutomation/Packages#22
Setup/Instructions: PokemonAutomation/ComputerControl#177

All singleplayer quests except "Pickup 10 items" are automated. That quest will be skipped, no rerolling, it only takes up one slot. No intention of doing multiplayer at this time, I've never found a ditto block in my life.

Some quests more reliable than others, ex. hatch egg and make sandwich are solid but the catch/photo quests are more sensitive to weather-induced lag since they have to navigate the area. I tried aiming for locations that are less likely to lag but there's no avoiding it outright. "Give your Pokemon a bath" depends on what Pokemon it ends up washing, it just moves the brush in a + shape. The program will retry quests anyway, so it will eventually complete the quests. I was able to do a successful run of 100 quests a few times.

Shiny checking - there's checking for overworld encounters that should work in theory, in practice all the targets are fixed spawns so they're full odds and I have no way of really testing it.

There are still improvements that can be done, quest processing logic was written with the assumption that most quests could not be automated so could be tweaked a bit, travel 500 meters could use sound detection (I don't have the sound file for it) to check when it is complete, could probably keep track of egg/TM position, etc. This things is 10 different programs in a trenchcoat, take your time reviewing. I need a break since it's been 3 weeks.

pifopi · 2024-03-03T23:58:49Z

SerialPrograms/Source/CommonFramework/OCR/OCR_TextMatcher.cpp

-uint64_t binomial_coefficient_u64(size_t degree, size_t index){
-    if (degree > 62){
-        throw InternalProgramError(nullptr, PA_CURRENT_FUNCTION, "Cannot go beyond degree 62.");
+double binomial_coefficient_u64(size_t degree, size_t index){


rename the method to binomial_coefficient_double
(or binomial_coefficient ? not sure what's best)

renamed it to binomial_coefficient_double

pifopi · 2024-03-04T00:02:10Z

SerialPrograms/Source/PokemonSV/Inference/PokemonSV_BlueberryQuestDetector.cpp

+        m_box = ImageFloatBox(0.604, 0.572, 0.282, 0.095);
+        break;
+    case QuestPosition::FOURTH:
+        m_box = ImageFloatBox(0.604, 0.749, 0.282, 0.096);


is the fourth intended to be bigger ? (difference is small anyway)

fixed, it was unintentional

pifopi · 2024-03-04T00:06:28Z

SerialPrograms/Source/PokemonSV/Options/PokemonSV_BBQOption.cpp

+            {OOEggs::KeepGoing, "keep-going",   "Keep Going - Warning: Bonus(Red) quests will be blocked!"},
+        },
+        LockMode::LOCK_WHILE_RUNNING,
+        OOEggs::Stop


Any reason not to do KeepGoing ? From my experience, it seems you can "stack up" red quest, meaining even if you do not complete the current red quest, you're already working on unlocking the next red quest

It only stacks up an additional two red quests. The bar fills green->gold->red and then stops there.

Mysticial · 2024-03-24T21:44:23Z

Given how big this change is. Let's split this up into smaller PRs that can go in incrementally. Especially the parts that are shared with existing programs so they can be tested separately. I'll comment on each file individually on what should probably be split out.

Mysticial · 2024-03-24T21:45:12Z

SerialPrograms/Source/CommonFramework/OCR/OCR_TextMatcher.cpp

Let's split this binomial refactor out to a separate PR. It's shared by a zillion other things so we can test it with those first.

Split out into #410.

Mysticial · 2024-03-24T21:52:13Z

SerialPrograms/Source/PokemonSV/Programs/PokemonSV_Terarium.cpp

+                    open_map_from_overworld(info, console, context);
+                }
+                catch (...) {
+                    //Stuck climbing on a wall? Center camera and try to backwards jump off.


The idea of getting off the wall is interesting since we have this problem elsewhere. (platform bot has this problem)

Here you're only retrying once. But from my experience that may not be enough depending on how you get stuck. So what I'm thinking is that we could pull this out in a generic "get off the wall" function with multiple retries before finally giving up.

Here you're using the open_map_from_overworld() to determine if you've successfully jumped off the wall. And I think in most of our other cases it's the same thing.

Exactly how we want to do this I'm not sure. Could either add this retry capability to open_map_from_overworld() itself or define a new function that wraps it.

Mysticial · 2024-03-24T21:54:39Z

SerialPrograms/Source/PokemonSV/Programs/PokemonSV_Terarium.cpp

Let's pull this file (and header) out into a separate PR. It looks self-contained enough to test and iterate on in isolation.

Pulled out into #409.

Mysticial · 2024-03-31T18:17:11Z

Looks like you can rebase this so we can see what's left to start chipping away at.

Mysticial · 2024-04-06T08:12:50Z

Looks like we need another rebase.

return_to_plaza() written

psychic, grass, dragon, ghost, ground

some catch photo fairy but its unreliable

targeting a scraggy, might need to change it

some cleanup for battles

Mysticial · 2024-04-11T22:27:04Z

SerialPrograms/Source/PokemonSV/Options/PokemonSV_BBQOption.h

+namespace NintendoSwitch{
+namespace PokemonSV{
+
+class BBQOption : public GroupOption, private ConfigOption::Listener {


Do you need to inherit from ConfigOption::Listener? I don't see an override for any of its functions.

Mysticial · 2024-04-11T22:33:12Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryQuests.h

+#include "PokemonSV/Options/PokemonSV_EncounterBotCommon.h"
+#include "PokemonSV/Options/PokemonSV_BBQOption.h"
+
+using namespace std;


Don't put this, especially in headers.

Mysticial · 2024-04-11T22:43:18Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryCatchPhoto.h

+namespace PokemonSV{
+
+//Navigate to a photo target
+CameraAngle quest_photo_navi(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext& context, BBQOption& BBQ_OPTIONS, BBQuests& current_quest);


You're not writing to BBQuests& current_quest right? If it's strictly an input parameter, take it by value since it's a primitive.

Mysticial · 2024-04-12T19:05:38Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryQuests.h

+//Open the quest panel and read in the current quests.
+//Currently only supports singleplayer.
+//For multiplayer, we will want keep track of which quest are gold/red and scroll cursor down until all of the current player's blue quests are in.
+std::vector<BBQuests> read_quests(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext& context, BBQOption& BBQ_OPTIONS);


Can BBQOption& BBQ_OPTIONS be made const? I don't think you're changing it. But at the same time, I'm don't remember if the getters are const. (since they internally take locks)

Mysticial · 2024-04-12T19:47:09Z

SerialPrograms/Source/PokemonSV/Options/PokemonSV_BBQOption.cpp

+    )
+    , NUM_EGGS(
+        "<b>Hatch Quest - Number of Eggs:</b><br>Amount of eggs located in your current box.",
+        LockMode::LOCK_WHILE_RUNNING, 30, 0, 30


Based on the way you're using this, it's safe to unlock. Though I don't see any legitimate use for editing while running other than fixing an incorrect value.

Mysticial · 2024-04-12T19:47:12Z

SerialPrograms/Source/PokemonSV/Options/PokemonSV_BBQOption.cpp

+    , CATCH_ON_WIN(true)
+    , NUM_RETRIES(
+        "<b>Number of Retries:</b><br>Reattempt a quest this many times if it fails.",
+        LockMode::LOCK_WHILE_RUNNING, 1, 0, 5


This one looks safe to unlock.

Mysticial · 2024-04-12T19:47:23Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryQuests.cpp

+            //Check eggs remaining.
+            if (n == BBQuests::hatch_egg && eggs_hatched >= BBQ_OPTIONS.NUM_EGGS) {
+                console.log("Out of eggs! Quest not possible.");
+                if (BBQ_OPTIONS.OUT_OF_EGGS == BBQOption::OOEggs::Reroll) {


If you make this a switch statement so that BBQ_OPTIONS.OUT_OF_EGGS is only read once, you can unlock this config.

Mysticial · 2024-04-13T00:28:53Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryCatchPhoto.cpp

+                        WallClock start = current_time();
+
+                        console.log("Opening ball menu...");
+                        while (ball_reader == "") {


A lot of duplicated code here between the Quick Ball and normal ball paths. Can you pull this out into a separate function where you just pass in the ball to use?

Mysticial · 2024-04-13T00:49:23Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryQuests.cpp

+    if (ret == 0) {
+        console.log("Battle menu detected.");
+
+       encounter_watcher.throw_if_no_sound();


bad indent. :)

move encounter watcher out of ret

Mysticial · 2024-04-13T05:19:57Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryCatchPhoto.cpp

@@ -608,6 +610,57 @@ void quest_catch_navi(const ProgramInfo& info, ConsoleHandle& console, BotBaseCo

 }

+void quest_catch_throw_ball(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext& context, Language language, std::string selected_ball) {


std::string selected_ball -> const std::string& selected_ball since it's not being modified and is not a primitive.

Mysticial · 2024-04-13T05:19:59Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryCatchPhoto.cpp

+                        MoveSelectDetector move_select(COLOR_BLUE);
+
+                        int ret_move_select = run_until(
+                        console, context,


Indentation

Mysticial · 2024-04-13T05:20:19Z

Last few nits. Otherwise, it's pretty much good to go.

Mysticial · 2024-04-13T17:44:16Z

SerialPrograms/Source/PokemonSV/Programs/Farming/PokemonSV_BlueberryCatchPhoto.h

@@ -31,7 +31,7 @@ void quest_photo(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext
 void quest_catch_navi(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext& context, const BBQOption& BBQ_OPTIONS, BBQuests current_quest);

 //Select and throw ball
-void quest_catch_throw_ball(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext& context, Language language, std::string selected_ball);
+void quest_catch_throw_ball(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext& context, Language language, const std::string selected_ball);


const reference, not just const. Remember that we don't want to copy non-trivial objects unless we need to.

pifopi reviewed Mar 4, 2024

View reviewed changes

Mysticial reviewed Mar 24, 2024

View reviewed changes

kichithewolf mentioned this pull request Mar 24, 2024

sv terarium navigation #409

Merged

kichithewolf force-pushed the BBQ-solo-farm branch from facca3b to aca2da3 Compare March 31, 2024 19:53

kichithewolf mentioned this pull request Apr 1, 2024

bbq quest detector and reader #416

Merged

kichithewolf added 20 commits April 6, 2024 12:20

BBQ farmer, options, functions file created

8798cac

return_to_plaza() written

read quests infra

bbba542

categorize quests, process quest list

673d20f

string to enum

b6154ea

make tm

0626969

travel 500 units

5bc9ca4

read and process quests vector, photo fly swim

84579c6

photo: coastal, canyon, savanna

b940cef

tera to defeat a wild pokemon, bugfixes

94fedab

catch quest, extra complete check, fix time option

e19c07b

sneak up, photo bug rock, some catchs

ec2738b

psychic, grass, dragon, ghost, ground

catch photo ice, kill wild tera

3f67c4b

some catch photo fairy but its unreliable

wash quest, some work on dark fight

ba1c78a

targeting a scraggy, might need to change it

separate out catch and photo quests, cleanup

72f2eb5

hatch egg quest

c5973c1

sandwiches, num retries option, enable saving

6f6fbae

some cleanup for battles

tera raid, bbq terarium movement functions

4c9f589

catch photo fairy dark fly, expand jump_glide_fly

4d4a92c

photo catch electric

d201fe9

catch photo steel poison

7aa5da4

kichithewolf added 8 commits April 6, 2024 12:21

out of eggs options, catch photo fighting

ff41bda

catch water, fix time for egg option, bugfixes

0065577

unlock options, improve flying, bugfixes

7dd901b

catch ice is now lapras, improved make tm, fixes

1385796

autobattle 10/30, move to dev mode

b2731c3

cleanup and fix warnings

baf9671

sandwich and navigation fixes for rebase

89d89b7

remove unused bool

3f5c314

kichithewolf force-pushed the BBQ-solo-farm branch from e687306 to 3f5c314 Compare April 6, 2024 16:22

Mysticial reviewed Apr 11, 2024

View reviewed changes

current_quest, remove unneeded

ac504dd

Mysticial reviewed Apr 12, 2024

View reviewed changes

const bbq options, adjust num retries

1c613b3

Mysticial reviewed Apr 12, 2024

View reviewed changes

unlock options

29e0d8f

Mysticial reviewed Apr 13, 2024

View reviewed changes

throw ball for catch quest

a44f36d

move encounter watcher out of ret

Mysticial reviewed Apr 13, 2024

View reviewed changes

const ball, indentation

2b44896

Mysticial reviewed Apr 13, 2024

View reviewed changes

const ref

25a5ce3

Mysticial merged commit e8adb61 into PokemonAutomation:main Apr 13, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BBQ Solo Farmer #407

BBQ Solo Farmer #407

kichithewolf commented Mar 3, 2024

pifopi Mar 3, 2024 •

edited

Loading

kichithewolf Mar 4, 2024

pifopi Mar 4, 2024

kichithewolf Mar 4, 2024

pifopi Mar 4, 2024

kichithewolf Mar 4, 2024

Mysticial commented Mar 24, 2024

Mysticial Mar 24, 2024

kichithewolf Mar 24, 2024

Mysticial Mar 24, 2024

Mysticial Mar 24, 2024

kichithewolf Mar 24, 2024

Mysticial commented Mar 31, 2024

Mysticial commented Apr 6, 2024

Mysticial Apr 11, 2024

Mysticial Apr 11, 2024

Mysticial Apr 11, 2024

Mysticial Apr 12, 2024

Mysticial Apr 12, 2024

Mysticial Apr 12, 2024

Mysticial Apr 12, 2024

Mysticial Apr 13, 2024

Mysticial Apr 13, 2024

Mysticial Apr 13, 2024

Mysticial Apr 13, 2024

Mysticial commented Apr 13, 2024

Mysticial Apr 13, 2024

		@@ -608,6 +610,57 @@ void quest_catch_navi(const ProgramInfo& info, ConsoleHandle& console, BotBaseCo

		}

		void quest_catch_throw_ball(const ProgramInfo& info, ConsoleHandle& console, BotBaseContext& context, Language language, std::string selected_ball) {

BBQ Solo Farmer #407

BBQ Solo Farmer #407

Conversation

kichithewolf commented Mar 3, 2024

pifopi Mar 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mysticial commented Mar 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mysticial commented Mar 31, 2024

Mysticial commented Apr 6, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mysticial commented Apr 13, 2024

Choose a reason for hiding this comment

pifopi Mar 3, 2024 •

edited

Loading