Feat/front #13
Feat/front #13
Conversation
superfluidDaoFront/src/App.css
Outdated
| @@ -0,0 +1,6 @@ | |||
| #root { | |||
| max-width: 1780px; | |||
There was a problem hiding this comment.
hard-coded px values are BAD, especially at the root element.
superfluidDaoFront/src/App.tsx
Outdated
| return ( | ||
| <> | ||
| <NavBar /> | ||
| <Routes> |
There was a problem hiding this comment.
A better way should be to use a Layout architecture to add the Navbar to each page and a future Footer I guess.
see https://reactrouter.com/en/main/start/concepts#layout-routes
superfluidDaoFront/public/vite.svg
Outdated
There was a problem hiding this comment.
where is the superfluid favicon :(
| @@ -0,0 +1,10 @@ | |||
| const CardYourDao = (props: { name: string; description: string }) => { | |||
There was a problem hiding this comment.
You can use destructuring here
| const CardYourDao = (props: { name: string; description: string }) => { | |
| type Props = { | |
| name: string; | |
| description: string; | |
| } | |
| const CardYourDao = ({ name, description }: Props) => { |
| Connect Wallet | ||
| </button> | ||
| <p className="text-xl">About us</p> | ||
| <p className="text-xl">DAOs</p> |
There was a problem hiding this comment.
I think you are supposed to use <Links> here (but I guess it's not ready yet)
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite + React + TS</title> |
| @@ -0,0 +1,34 @@ | |||
| { | |||
| "name": "superfluiddaofront", | |||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0", | ||
| "react-router-dom": "^6.16.0", | ||
| "web3": "^4.1.2" |
There was a problem hiding this comment.
on avait dis viem et wagmi, pas web3
| } | ||
|
|
||
| body { | ||
| margin: 0; |
There was a problem hiding this comment.
tailwind reset deja le margin/padding du body normalement
| body { | ||
| margin: 0; | ||
| padding: 0; | ||
| background-image: url("https://img.freepik.com/premium-vector/white-abstract-background-paper-style_23-2148389998.jpg?w=2000"); |
There was a problem hiding this comment.
faut jamais utiliser des image externe (si elle est down t'es niqué)
telecharge la et met la dans le /static
| description: string; | ||
| }; | ||
|
|
||
| const CardYourDao = (props: Props) => { |
| <img src={logo} alt="logo" className="w-25 h-20" /> | ||
| </Link> | ||
| <div className="flex-row-reverse flex gap-20 items-center w-full"> | ||
| <button className="btn btn-outline btn-success rounded-full"> |
There was a problem hiding this comment.
faudrait connecter le wallet un jour.....
| }); | ||
|
|
||
| // Créer une instance Web3 pour interagir avec MetaMask | ||
| const web3 = new Web3((window as any).ethereum); |
There was a problem hiding this comment.
on avait dit wagmi et pas web3 :(
There was a problem hiding this comment.
mets ca dans le index.css, t'as pas besoin de plusieurs fichiers css si c'est pour mettre 2 truc dedans
Description
Please provide a detailed description of what was done in this PR.
Precise the issue that you are resolving.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it.
Checklist
Additional comments
Please post additional comments in this section if you have them, otherwise delete it.