Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte/dev #7

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Svelte/dev #7

merged 7 commits into from
Feb 2, 2024

Conversation

sephorah
Copy link
Contributor

Description

We wrote the first steps of the Svelte subject for day 5.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functional / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

sephorah and others added 5 commits December 24, 2023 19:58
@sephorah
feat: soft day05 svelte up to step 7
464285f
@YlanGarnier
feat(day05 svelte): step 5 and library change
42eb1aa 
add: step 5 (tests)
fix: swapped 'svelte-spa-router' routing library for 'svelte-routing' because SPR use hash-based routing and the urls aren't 'clean'
@YlanGarnier
feat(day05 svelte): fix step 7 add artist button
c725423
@sephorah
feat: readme (not completed)
08242ab
@sephorah
Update README.md
fb1d990
@sephorah sephorah added the enhancement New feature or request label Jan 20, 2024
@sephorah sephorah requested a review from Molaryy January 20, 2024 16:50
@sephorah sephorah self-assigned this Jan 20, 2024
Molaryy
Molaryy reviewed Jan 20, 2024
View reviewed changes
software/day05/Svelte/README.md
npm run dev
```

If you get a page with the Vite and the Svelte logos, then you can continue 🚀
Copy link
Contributor

@Molaryy Molaryy Jan 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an image so they don't get confused about what the exact result should look like?

Copy link
Contributor Author

@sephorah sephorah Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added images previews for each step (except the step 4 about Cypress)
I also updated the README to follow the template you talked about

@Molaryy Molaryy marked this pull request as ready for review February 2, 2024 00:14
Molaryy
Molaryy approved these changes Feb 2, 2024
View reviewed changes
software/day05/Svelte/README.md
Install all the packages we're going to use for this day:

```sh
npm i svelte-routing cypress flowbite flowbite-svelte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm i -> npm install

Always better to add more details

software/day05/Svelte/README.md Outdated

**Requirements:**
- The Home page must contain:
- A `Button` to the Register page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding "A Button" each time they need to create a button you can tell: Create 2 buttons to register or login into the page.

Same the for the othert tasks.

software/day05/Svelte/README.md Outdated
- You must create the file `src/pages/Login.svelte`.
- You must create the file `src/app/Routes.svelte` with a Svelte Component containing the Routes inside, called in `src/App.svelte`.

**Tips:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace Tips by Documentation

software/day05/Svelte/README.md Outdated
> Try to display the `rating` using 5 stars ⭐

**Tips:**
- The Flowbite Svelte [Gallery](https://flowbite-svelte.com/docs/components/gallery#mainContent), [Navbar](https://flowbite-svelte.com/docs/components/navbar), [Link][https://flowbite-svelte.com/docs/typography/link] and [Rating](https://flowbite-svelte.com/docs/components/rating) components will be useful for this dashboard 😉
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Link][https://flowbite-svelte.com/docs/typography/link]
Link

software/day05/Svelte/README.md


***
### **⚠️ Important note ⚠️**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding 1 or 2 bonuses? Don't need to do a correction for the bonuses tho.

@Molaryy Molaryy changed the base branch from main to soft/dev February 2, 2024 00:16
@Molaryy Molaryy merged commit e36f020 into soft/dev Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Molaryy Molaryy Molaryy approved these changes

Assignees

@sephorah sephorah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sephorah @Molaryy @YlanGarnier