Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding multiple Nodes to e2e cluster #286

Merged
merged 3 commits into from
Jun 28, 2022
Merged

adding multiple Nodes to e2e cluster #286

merged 3 commits into from
Jun 28, 2022

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Jun 22, 2022 •
edited
Loading

This PR

  • adds multiple Nodes to the e2e configuration with kind
  • modifies gameserverapi and controller kustomization YAML files so that both of these are deployed on the first Node. This way we can do the port forwarding properly to the host machine running the e2e test

Opportunistically fixing a couple of other issues as well.

@dgkanatsios dgkanatsios force-pushed the kindnodes branch 2 times, most recently from 0e25852 to 1c92218 Compare June 28, 2022 03:22
@dgkanatsios dgkanatsios marked this pull request as ready for review June 28, 2022 03:23
@dgkanatsios dgkanatsios requested a review from javier-op June 28, 2022 03:24
@dgkanatsios dgkanatsios added the area/tests Make sure things don't break, unit tests. label Jun 28, 2022
@dgkanatsios dgkanatsios force-pushed the kindnodes branch 3 times, most recently from 52b3b84 to dad9ca1 Compare June 28, 2022 06:26
@dgkanatsios dgkanatsios merged commit b88a44d into main Jun 28, 2022
@dgkanatsios dgkanatsios deleted the kindnodes branch June 28, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javier-op javier-op javier-op approved these changes

Assignees
No one assigned
Labels
area/tests Make sure things don't break, unit tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgkanatsios @javier-op