feat: modernise, drop support for php < 7.4, migrate tests and config… #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for phpUnit 9, replace travis with github actions
Chris53897
force-pushed
the
feature/modernise
branch
from
30ce239 to
90f9057
Compare
|
Hi @triplepoint. Could you please look into this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for phpUnit 9
Replace travis with github actions
One test is failing local on php 8.1. Look like the value needs to be rounded now.
https://github.com/Chris53897/php-units-of-measure/actions/runs/4092077704/jobs/7056564063
`1) PhpUnitsOfMeasureTest\PhysicalQuantity\LengthTest::testToInches
Failed asserting that 24.000000000000004 matches expected 24.
/home/runner/work/php-units-of-measure/php-units-of-measure/tests/PhysicalQuantity/LengthTest.php:159`