Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 Support #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rogervila
Copy link

@rogervila rogervila commented Dec 13, 2022

Add PHP 8 versions to tests.

@rogervila
Copy link
Author

Hi @triplepoint,
It looks that Travis's configuration is broken. Is there something I can do on my side to fix it?

Thank you!

@Chris53897
Copy link

This could be fixed by https://github.com/PhpUnitsOfMeasure/php-units-of-measure/pull/91/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd

@rogervila
Copy link
Author

This could be fixed by https://github.com/PhpUnitsOfMeasure/php-units-of-measure/pull/91/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd

Yes, I will drop this PR if yours is merged.

I have added PHP 8.3 to the Travis config. Can you add 8.3 support on your branch too?

@Chris53897
Copy link

I have added now a testrun for php 8.3 in my PR. https://github.com/PhpUnitsOfMeasure/php-units-of-measure/pull/91/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants