feature: implement dynamic in

closes #347
PhpGt · Aug 15, 2023 · 8fd2602 · 8fd2602
1 parent 0492885
commit 8fd2602
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 8 deletions.
diff --git a/src/Query/SqlQuery.php b/src/Query/SqlQuery.php
@@ -118,19 +118,22 @@ public function injectSpecialBindings(
 	}
 
 	public function injectDynamicBindings(string $sql, array &$data):string {
-		$sql = $this->injectDynamicBindingsValueset($sql, $data);
+		$sql = $this->injectDynamicBindingsValueSet($sql, $data);
+		$sql = $this->injectDynamicIn($sql, $data);
 		return $sql;
 	}
 
-	private function injectDynamicBindingsValueset($sql, &$data):string {
+	private function injectDynamicBindingsValueSet(string $sql, array &$data):string {
 		$pattern = '/\(\s*:__dynamicValueSet\s\)/';
 		if(!preg_match($pattern, $sql, $matches)) {
 			return $sql;
 		}
+		if(!isset($data["__dynamicValueSet"])) {
+			return $sql;
+		}
 
 		$replacementRowList = [];
-		$originalKeys = array_keys($data[0]);
-		foreach($data as $i => $kvp) {
+		foreach($data["__dynamicValueSet"] as $i => $kvp) {
 			$indexedRow = [];
 			foreach($kvp as $key => $value) {
 				$indexedKey = $key . "_" . str_pad($i, 5, "0", STR_PAD_LEFT);
@@ -141,6 +144,7 @@ private function injectDynamicBindingsValueset($sql, &$data):string {
 			unset($data[$i]);
 			array_push($replacementRowList, $indexedRow);
 		}
+		unset($data["__dynamicValueSet"]);
 
 		$replacementString = "";
 		foreach($replacementRowList as $i => $indexedKeyList) {
@@ -160,6 +164,20 @@ private function injectDynamicBindingsValueset($sql, &$data):string {
 		return str_replace($matches[0], $replacementString, $sql);
 	}
 
+	private function injectDynamicIn(string $sql, array &$data):string {
+		$pattern = '/\(\s*:__dynamicIn\s\)/';
+		if(!preg_match($pattern, $sql, $matches)) {
+			return $sql;
+		}
+		if(!isset($data["__dynamicIn"])) {
+			return $sql;
+		}
+
+		$replacementString = implode(", ", $data["__dynamicIn"]);
+		unset($data["__dynamicIn"]);
+		return str_replace($matches[0], "( $replacementString )", $sql);
+	}
+
 	/**
 	 * @param array<string, mixed>|array<mixed> $bindings
 	 * @return array<string, string>|array<string>

diff --git a/test/phpunit/Query/SqlQueryTest.php b/test/phpunit/Query/SqlQueryTest.php
@@ -313,9 +313,11 @@ public function testDynamicBindingsInsertMultiple(
 		file_put_contents($filePath, $sql);
 		$query = new SqlQuery($filePath, $this->driverSingleton());
 		$data = [
-			["id" => 100, "name" => "first inserted"],
-			["id" => 101, "name" => "second inserted"],
-			["id" => 102, "name" => "third inserted"],
+			"__dynamicValueSet" => [
+				["id" => 100, "name" => "first inserted"],
+				["id" => 101, "name" => "second inserted"],
+				["id" => 102, "name" => "third inserted"],
+			],
 		];
 		$originalData = $data;
 		$injectedSql = $query->injectDynamicBindings($sql, $data);
@@ -329,13 +331,41 @@ public function testDynamicBindingsInsertMultiple(
 		self::assertStringContainsString(":name_00001", $injectedSql);
 		self::assertStringContainsString(":name_00002", $injectedSql);
 
-		foreach($originalData as $i => $kvp) {
+		foreach($originalData["__dynamicValueSet"] as $i => $kvp) {
 			foreach($kvp as $key => $value) {
 				$indexedKey = $key . "_" . str_pad($i, 5, "0", STR_PAD_LEFT);
 				self::assertSame($data[$indexedKey], $value);
 			}
 		}
+
+		self::assertArrayNotHasKey("__dynamicValueSet", $data);
+	}
+
+	/**
+	 * @dataProvider \Gt\Database\Test\Helper\Helper::queryPathNotExistsProvider()
+	 */
+	public function testDynamicBindingsWhereIn(
+		string $queryName,
+		string $queryCollectionPath,
+		string $filePath
+	) {
+		$sql = "select `id`, `name` from `test_table` where `createdAt` > :startDate and `id` in ( :__dynamicIn ) limit 10";
+		file_put_contents($filePath, $sql);
+		$query = new SqlQuery($filePath, $this->driverSingleton());
+		$data = [
+			"startDate" => "2020-01-01",
+			"__dynamicIn" => [1, 2, 3, 4, 5, 50, 60, 70, 80, 90],
+		];
+		$originalData = $data;
+		$injectedSql = $query->injectDynamicBindings($sql, $data);
+
+		self::assertStringNotContainsString("dynamicIn", $injectedSql);
+
+		self::assertStringContainsString("where `createdAt` > :startDate and `id` in ( 1, 2, 3, 4, 5, 50, 60, 70, 80, 90 ) limit 10", $injectedSql);
+		self::assertArrayNotHasKey("__dynamicIn", $data);
+		self::assertSame("2020-01-01", $data["startDate"]);
 	}
+
 	/**
 	 * @dataProvider \Gt\Database\Test\Helper\Helper::queryPathNotExistsProvider()
 	 */