Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set environment variables on sub-process #49

Merged
merged 9 commits into from
May 8, 2024
Merged

Set environment variables on sub-process #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8224dd3
test: fix changed process execution
g105b May 8, 2024
9febcc3
test: upgrade phpunit
g105b May 8, 2024
c90ed5b
test: implement mess detector and code sniffer
g105b May 8, 2024
24e04d8
ci: upgrade ci workflows
g105b May 8, 2024
dd86f55
ci: use pcntl
g105b May 8, 2024
820794a
ci: php 8.1 compatibility
g105b May 8, 2024
bb74f6f
feature: set environment variables
g105b May 8, 2024
25f2472
Merge branch 'master' of github.com:PhpGt/Daemon into 239-environment…
g105b May 8, 2024
53bc4fb
test: assert multiple environment variables can be set
g105b May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Process.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class Process {
/** @var array<string, mixed> */
protected array $status;
protected bool $isBlocking = false;
/** @var array<string, string> */
protected array $env = [];

public function __construct(string...$command) {
$this->command = $command;
Expand All @@ -31,6 +33,10 @@ public function setExecCwd(string $cwd):void {
$this->cwd = $cwd;
}

public function setEnv(string $key, string $value):void {
$this->env[$key] = $value;
}

/**
* Runs the command in a concurrent thread.
* Sets the input, output and errors streams.
Expand All @@ -54,7 +60,7 @@ public function exec():void {
$this->command,
$descriptor,
$this->pipes,
// env_vars: $this->env,
env_vars: $this->env,
);
if(!$this->process) {
throw new CommandNotFoundException($this->command[0]);
Expand Down
20 changes: 19 additions & 1 deletion test/phpunit/ProcessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,4 +163,22 @@ public function testExecBlocking() {
$sut->exec();
self::assertFalse($sut->isRunning());
}
}

public function testSetEnv() {
$sut = new Process("printenv");
$sut->setEnv("NAME", "PHPUnit");
$sut->exec();
$output = $sut->getOutput();
self::assertStringContainsString("NAME=PHPUnit\n", $output);
}

public function testSetEnv_multiple() {
$sut = new Process("printenv");
$sut->setEnv("NAME", "PHPUnit");
$sut->setEnv("TEST", "setEnv");
$sut->exec();
$output = $sut->getOutput();
self::assertStringContainsString("TEST=setEnv\n", $output);
self::assertStringContainsString("NAME=PHPUnit\n", $output);
}
}
Loading