Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap Photonlib via nanobind #1426

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft

Wrap Photonlib via nanobind #1426

wants to merge 27 commits into from

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Sep 17, 2024 •
edited
Loading

TODO:

  • Not hard code Linux in copy task dependencies
  • Find an intern to wrap all the other bits of Photonlib
  • Add this to CI and build for all platforms/python versions

@mcm001 mcm001 changed the title Wrap Photonlib via nanobind Wrap Photonlib via nano/pybind Sep 23, 2024
gerth2
gerth2 reviewed Sep 25, 2024
View reviewed changes
photon-lib/src/main/pybindings/cpp/photonlib_pybind.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait srsly this is it? All those months of experiments and pain for this one file?

Copy link
Contributor Author

@mcm001 mcm001 Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! This is what we've poured blood sweat and tears into. All we really needed to do was to cut out the middleman in the build system lol

@mcm001 mcm001 changed the title Wrap Photonlib via nano/pybind Wrap Photonlib via nanobind Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerth2 gerth2 gerth2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcm001 @gerth2