fix: page format letter not working properly (#38)

essaydownload_form.php

@@ -168,13 +168,13 @@ protected function standard_preference_fields(MoodleQuickForm $mform) {
      * @return void
      */
     protected function pdf_layout_fields(MoodleQuickForm $mform) {
-        $mform->addElement('select', 'page', get_string('page', 'quiz_essaydownload'), [
+        $mform->addElement('select', 'pageformat', get_string('page', 'quiz_essaydownload'), [
             'a4' => get_string('pagea4', 'quiz_essaydownload'),
             'letter' => get_string('pageletter', 'quiz_essaydownload'),
         ]);
-        $mform->setType('page', PARAM_ALPHA);
-        $mform->setDefault('page', 'a4');
-        $mform->disabledIf('page', 'fileformat', 'neq', 'pdf');
+        $mform->setType('pageformat', PARAM_ALPHANUM);
+        $mform->setDefault('pageformat', 'a4');
+        $mform->disabledIf('pageformat', 'fileformat', 'neq', 'pdf');
 
         $margingroup = [];
         $margingroup[] = $mform->createElement('text', 'marginleft', '', ['size' => 3]);

report.php

@@ -555,7 +555,7 @@ protected function generate_pdf(string $text, string $header = '', string $subhe
             $text = $this->workaround_atto_font_size_issue($text);
         }
 
-        $doc = new customTCPDF('P', 'mm', $this->options->pageformat);
+        $doc = new customTCPDF('P', 'mm', strtoupper($this->options->pageformat));
 
         $doc->SetCreator('quiz_essaydownload plugin for Moodle LMS');
         $doc->SetAuthor($author);

tests/behat/form.feature

@@ -54,7 +54,7 @@ Feature: Validation and display of the form
     When I set the field "fileformat" to "txt"
     Then the "source" "select" should be disabled
     And the "fixremfontsize" "field" should be disabled
-    And the "page" "select" should be disabled
+    And the "pageformat" "select" should be disabled
     And the "marginleft" "field" should be disabled
     And the "marginright" "field" should be disabled
     And the "margintop" "field" should be disabled