Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/added header based logger + addedrisk_start_time and enforcer_start_time fields to activities #171

Merged
merged 13 commits into from
Dec 21, 2023
Merged

Feature/added header based logger + addedrisk_start_time and enforcer_start_time fields to activities #171

merged 13 commits into from
Dec 21, 2023

Conversation

chen-zimmer-px
Copy link
Contributor

No description provided.

@chen-zimmer-px chen-zimmer-px changed the base branch from master to dev November 28, 2023 06:53
ori-gold-px
ori-gold-px requested changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@ori-gold-px ori-gold-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough. Just two things:

(1) holding off on approving until node core is updated and released so package.json can be updated
(2) E2E tests are failing - please resolve

ori-gold-px
ori-gold-px approved these changes Dec 14, 2023
View reviewed changes
px_metadata.json Outdated Show resolved Hide resolved
px_metadata.json Show resolved Hide resolved
px_metadata.json Outdated Show resolved Hide resolved
@chen-zimmer-px chen-zimmer-px changed the title Feature/added header based logger + addedsending_risk_timestamp and start_enforcer_timestamp fields to activities Feature/added header based logger + addedrisk_start_time and enforcer_start_time fields to activities Dec 17, 2023
@chen-zimmer-px chen-zimmer-px merged commit f9e2bc8 into dev Dec 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori-gold-px ori-gold-px ori-gold-px approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chen-zimmer-px @ori-gold-px @DanBezalelpx