Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty payload handling in pxhttpc #293

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Conversation

pxjohnny
Copy link
Contributor

@pxjohnny pxjohnny commented Dec 7, 2023

  • Fixes uneeded and wrong error message showing in debug for async activities:
    Dec 7, 09:37:21 AM: 01HH2BCD info [human-enforcer] [PerimeterX - DEBUG][PX1yz6W67d] - callServer default callback. Error: {"errorReason":"invalid_response","errorMessage":"unable to get data from response body: ","httpStatus":200,"httpMessage":"OK"}
  • if the status is 200, even in the body is empty (content-length: 0), it shouldnt show this message

@pxjohnny pxjohnny requested a review from ori-gold-px December 7, 2023 16:02
lib/pxhttpc.js Outdated Show resolved Hide resolved
@pxjohnny pxjohnny requested a review from ori-gold-px December 7, 2023 20:39
Copy link
Collaborator

@ori-gold-px ori-gold-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please add to CHANGELOG :)

@pxjohnny pxjohnny requested a review from ori-gold-px December 10, 2023 09:02
@pxjohnny pxjohnny merged commit 3a56cae into dev Dec 15, 2023
8 of 9 checks passed
@pxjohnny pxjohnny deleted the fix/empty_response_handling branch December 15, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants