Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performace Improvements #34

Merged
merged 8 commits into from
Dec 15, 2024
Merged

Performace Improvements #34

merged 8 commits into from
Dec 15, 2024

Conversation

BenBaryoPX
Copy link
Collaborator

  • Replace estraverse with a local implementation and remove the dependency
  • Refactor code to streamline node extraction and scope mapping
  • Add comments to the code
  • Remove async implementation which is no longer more performant than the sync version
  • Replace external log function in the Arborist with the logger
  • Set the scriptHash only on the root node instead of on each node

@BenBaryoPX
Refactor code to use estraverse.traverse only to extract the nodes,…
d71f7cc 
… and move the rest of the logic out of the `traverse` method.
@BenBaryoPX
Fix printing the node instead of the nodeId
bbd4766
@BenBaryoPX
Fix scopes are collected before nodeId is given by numbering the scop…
c7b8ac6 
…es according to the start location of the scope node.
@BenBaryoPX
Refactor code to improve performance.
90ae3d2 
Add comments explaining the process.
Remove async functions as they are no longer more performant than the sync versions
@BenBaryoPX
Replace external log function with internal logger.
4d8520c 
Refactor code to improve performance.
@BenBaryoPX
Replace external log function with internal logger.
d0dbbdd 
Refactor code to improve performance.
@BenBaryoPX
Refactor to improve performance:
cee8807 
- Set scriptHash only on the root element instead of iterating over the entire tree.
- Replace +new Date() with Date.now() to improve performance
@BenBaryoPX
Remove the redundant estraverse
72937d2
@BenBaryoPX BenBaryoPX self-assigned this Dec 15, 2024
@BenBaryoPX BenBaryoPX merged commit 8acd702 into main Dec 15, 2024
3 checks passed
@BenBaryoPX BenBaryoPX deleted the perf_improvements branch December 15, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BenBaryoPX BenBaryoPX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BenBaryoPX