Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple use of the same image fix #22

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

shaharpx
Copy link
Contributor

Cleanup phase failed when using the same image for multiple components due to a failure in removing the image
more than once. To fix this - ignored that specific issue "reference does not exist" when that error is returned
from the docker remove request

…s due to a failure in removing the image

more than once. To fix this - ignored that specific issue "reference does not exist" when that error is returned
from the docker remove request
@avivpxi
Copy link
Collaborator

avivpxi commented Aug 22, 2024

@shaharpx
Lack of conventions on the Go community generates quirky error handling (if i remember correctly, docker does not create proper typing for errors or ways to identify, forcing us to do string contains).
Aside from that, sounds reasonable that if docker still uses the image it won't be deleted and it won't trigger a failure on the envite flow.
Approved

Copy link

@vladpx vladpx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaharpx shaharpx merged commit 3e7bba4 into main Aug 24, 2024
4 checks passed
@shaharpx shaharpx deleted the fix_cleanup_when_using_the_same_image_more_than_once branch August 24, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants