add redis seed #19
Merged
add redis seed #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivpxi
reviewed
May 28, 2024
cmd/envite/redis.go
Outdated
|
|
||
| // buildRedisSeed is a builder function that constructs a new Redis seed component. | ||
| // It takes a byte slice of JSON data as input. | ||
| // The function attempts to parse the JSON data into a mongo.SeedConfig struct, which defines the configuration |
There was a problem hiding this comment.
mongo.SeedConfig -> redis.SeedConfig
avivpxi
reviewed
May 28, 2024
cmd/envite/redis.go
Outdated
| // It takes a byte slice of JSON data as input. | ||
| // The function attempts to parse the JSON data into a mongo.SeedConfig struct, which defines the configuration | ||
| // for a Redis seed component. If the JSON data is successfully parsed, it then uses this configuration | ||
| // to instantiate and return a new MongoDB seed component via the redis.NewSeedComponent function. |
avivpxi
reviewed
May 28, 2024
seed/redis/config.go
Outdated
| // SeedData represents data for a redis hash. | ||
| type SeedData struct { | ||
| // Key - the name of the redis key | ||
| Key string `json:"key,omitempty"` |
There was a problem hiding this comment.
my only comment on the config is that this structure will only let us support HSet, or at least block the name Key for this specific use.
What do you think about something like this:
// SeedConfig represents the configuration for the redis seed component.
type SeedConfig struct {
// Address - a valid redis server address to connect to
Address string `json:"address,omitempty"`
// ClientProvider - can be used as an alternative to Address, provides a redis client to use.
// available only via code, not available in config files.
// if both ClientProvider and Address are provided, ClientProvider is used.
ClientProvider func() (*redis.Client, error) `json:"-"`
SetKeys []*Set `json:"set_keys"`
HSetKeys []*HSet `json:"hset_keys"`
}
type Set struct {
Key string `json:"key"`
Value string `json:"value"`
TTL time.Duration `json:"ttl"`
}
type HSet struct {
Key string `json:"key"`
Values map[string]string `json:"values"`
TTL time.Duration `json:"ttl"`
}this will allow us to add future support for other data types as well without breaking anything
WDYT?
etrpx
commented
May 29, 2024
cmd/envite/redis.go
Outdated
|
|
||
| // buildRedisSeed is a builder function that constructs a new Redis seed component. | ||
| // It takes a byte slice of JSON data as input. | ||
| // The function attempts to parse the JSON data into a mongo.SeedConfig struct, which defines the configuration |
cmd/envite/redis.go
Outdated
| // It takes a byte slice of JSON data as input. | ||
| // The function attempts to parse the JSON data into a mongo.SeedConfig struct, which defines the configuration | ||
| // for a Redis seed component. If the JSON data is successfully parsed, it then uses this configuration | ||
| // to instantiate and return a new MongoDB seed component via the redis.NewSeedComponent function. |
seed/redis/config.go
Outdated
| // SeedData represents data for a redis hash. | ||
| type SeedData struct { | ||
| // Key - the name of the redis key | ||
| Key string `json:"key,omitempty"` |
avivpxi
reviewed
May 29, 2024
seed/redis/component.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (r *SeedComponent) HashSetEntries(ctx context.Context, err error, client *redis.Client) error { |
avivpxi
reviewed
May 29, 2024
seed/redis/component.go
Outdated
|
|
||
| func (r *SeedComponent) setEntries(ctx context.Context, err error, client *redis.Client) error { | ||
| for _, entry := range r.config.Entries { | ||
| err = client.Set(ctx, entry.Key, entry.Value, entry.TTL*time.Second).Err() |
There was a problem hiding this comment.
entry.TTL*time.Second is a mistake, it's already a duration - multipying by time.Second will just multiply the duration by 1000^3 (source code)
avivpxi
reviewed
May 29, 2024
seed/redis/component.go
Outdated
| return err | ||
| } | ||
| if hEntry.TTL > 0 { | ||
| err = client.Expire(ctx, hEntry.Key, hEntry.TTL*time.Second).Err() |
- change method to private
avivpxi
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.