Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging color miss and log location not working #938

Closed
wants to merge 1 commit into from
Closed

Fix logging color miss and log location not working #938

wants to merge 1 commit into from

Conversation

haoming29
Copy link
Contributor

@haoming29 haoming29 commented Mar 12, 2024 •
edited
Loading

Fixes #918

@haoming29 haoming29 added bug Something isn't working critical High priority for next release labels Mar 12, 2024
@haoming29 haoming29 added this to the v7.7.0 milestone Mar 12, 2024
@haoming29
Copy link
Contributor Author

The fix is invalid with how logrus was set up. Logrus won't create a new entry if the level of the log is smaller than the logging threshold and we reply heavily on intercepting all logs for the code to work. This fix is not effective.

@haoming29 haoming29 closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working critical High priority for next release
Projects
None yet
Milestone
v7.7.0
Development

Successfully merging this pull request may close these issues.

Pelican log doesn't have color coding for tty terminal
1 participant
@haoming29