-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow origins to export multiple prefixes #927
Conversation
@CannonLock Just wanted to ping you to make sure you see the new addition here from over the weekend. We now have the object:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review - still need to dig deep into some of the code.
Other files that also contain environment params to fix: github_scripts/stat_test.sh |
@jhiemstrawisc Is this the full set of values that
|
Good catch, I missed one there. There's also "Reads", which turns on authenticated reads. Setting "PublicReads" implies "Reads" (you can't read publicly if you don't allow any reading at all), but a capabilities flow without either "Reads" or "PublicReads" implies that it's a write-only origin. |
@jhiemstrawisc can multiple values be true at the same time or can you only pick one? |
Multiple values. You can have Writes and PublicReads both be true, for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me, but obviously needs a rebase for the merge conflicts and hopefully Cannon's fixes in there, soon.
This should be the first step toward multi-export origins. While I didn't get things sorted out for S3, the fact is the S3 plugin doesn't really support that yet anyway. For now, this appears to be working with POSIX, which is the majority of origins anyway. In particular, the larges addition as I see it is the `GetOriginExports` function, which allows us to construct a list of OriginExports that can be used in a standard way elsewhere.
c2654c7
to
4282531
Compare
9152efc
to
fcc923f
Compare
This should be the first step toward multi-export origins. While I didn't get
things sorted out for S3, the fact is the S3 plugin doesn't really support that
yet anyway. For now, this appears to be working with POSIX, which is the majority
of origins anyway.
In particular, the larges addition as I see it is the
GetOriginExports
function,which allows us to construct a list of OriginExports that can be used in a standard
way elsewhere.
Closees #858