Configure 'sec.protbind' for public origins #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
approved these changes
Mar 7, 2024
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy caches won't work with public pelican origins without the ability to fallback to xroot protocol. This adds
sec.protbind * noneto the origin config if the origin is run withOrigin.EnablePublicReads: true. Note that when we have multi-exports origins configured from #858, we'll have to handle this more carefully.So that the reviewer doesn't have to hunt, the addition to the struct in
xrootd/xrootd_configisEnablePublicReads. I had to adjust spacing to make the linter happy, and it buried the change.To test, try running an origin with
Origin.EnablePublicReadsset to true and then to false. You should see thesec.protbind * noneline appear in the xrootd config for public, and be absent for non-public.