Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent snapshot from incrementing version #1790

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

CannonLock
Copy link
Contributor

@CannonLock CannonLock commented Dec 3, 2024

Closes: #1163

@CannonLock CannonLock requested a review from bbockelm December 3, 2024 20:17
@CannonLock
Copy link
Contributor Author

Easy fix, hopefully easy review. You can see the issue is resolved from the log snapshots of the docker builds before and after the change.

From the docker build action here:

#22 0.203     • git state                                      commit=8125e86ae6e306297b7df7019307591fbb2f6535 branch=HEAD current_tag=v0.0.0 previous_tag=<unknown> dirty=false
#22 0.203     • pipe skipped                                   reason=disabled during snapshot mode
#22 0.203   • parsing tag
#22 0.203   • setting defaults
#22 0.207   • snapshotting
#22 0.207     • building snapshot...                           version=0.0.0

From previous docker build actions:

#23 0.150     • git state                                      commit=b353acaa7b807243a6feffb9fa4480fa77f34031 branch=HEAD current_tag=v0.0.0 previous_tag=<unknown> dirty=false
#23 0.150     • pipe skipped                                   reason=disabled during snapshot mode
#23 0.151   • parsing tag
#23 0.151   • setting defaults
#23 0.154   • snapshotting
#23 0.154     • building snapshot...                           version=0.0.1-next

@jhiemstrawisc jhiemstrawisc requested review from jhiemstrawisc and removed request for bbockelm December 12, 2024 19:06
Copy link
Member

@jhiemstrawisc jhiemstrawisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reassigned the review to myself since I was mucking with versioning/goreleaser in a sidequest.

Only comment is that it looks like snapshot.name_template is deprecated. Can you update to snapshot.version_template as suggested by their docs?

I also see this error:

 only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration

The fix appears to be adding version: 2 to .goreleaser.yaml. I tested this by adding the key at the beginning of goreleaser:

project_name: pelican
version: 2

Seemed to quiet things down. Thoughts?

@CannonLock CannonLock added the bug Something isn't working label Dec 16, 2024
@CannonLock
Copy link
Contributor Author

@jhiemstrawisc We are using goreleaser/goreleaser:v1.21.0 in the container that I am fixing. Can we create a new ticket to upgrade that and address these deprecations and warnings there?

@jhiemstrawisc
Copy link
Member

New ticket opened: #1835

@jhiemstrawisc jhiemstrawisc merged commit 8a715c2 into PelicanPlatform:main Dec 17, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version reported by Pelican doesn't match version tagged in our production containers
2 participants