Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update origin documentation, including first pass at S3 config #1086

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Update origin documentation, including first pass at S3 config #1086

merged 4 commits into from
Apr 17, 2024

Conversation

jhiemstrawisc
Copy link
Member

Closes #925

@haoming29 haoming29 added the documentation Improvements or additions to documentation label Apr 10, 2024
haoming29
haoming29 suggested changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the S3 docs and improving docs on the configuration! Some changes requested:

turetske
turetske requested changes Apr 11, 2024
View reviewed changes
docs/pages/serving_an_origin.mdx Outdated Show resolved Hide resolved
@jhiemstrawisc jhiemstrawisc requested a review from turetske April 16, 2024 15:14
@jhiemstrawisc jhiemstrawisc requested a review from haoming29 April 16, 2024 15:14
@jhiemstrawisc jhiemstrawisc merged commit a5086ac into PelicanPlatform:main Apr 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoming29 haoming29 haoming29 approved these changes

@turetske turetske turetske approved these changes

@brianhlin brianhlin Awaiting requested review from brianhlin

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to run a pelican s3 origin
3 participants
@jhiemstrawisc @turetske @haoming29