Sets Origin.Port to fix "port already in use" error that occurs occas… #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionally in S3 Origin tests
turetske
force-pushed
the
fix-flaky-s3-origin-test
branch
from
e286476 to
83017e5
Compare
|
Did the wrong branch get force pushed here? It doesn't seem like the code changes match the PR title. |
This was two issues. One, after realizing it was a more complex issue than the port change and that broke everything more, we decided to remove the virtual mode test (since it wasn't really serving a purpose right now) and I didn't update the description AND it looks like a rebase off of main went funky. I'll repair it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ionally in S3 Origin tests