Update login UI #1030
Merged
Update login UI #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CannonLock
commented
Apr 2, 2024
CannonLock
commented
- Memory Cache User and other information
- Remove Jumpiness from various pages that rely on this now cached information
- Add a User button
- Rework the login page to push towards Oauth login
haoming29
suggested changes
Apr 2, 2024
1 task
Merged
|
@haoming29 Going to have to move the lack of returning to the original place to next release. I am not sure why my implementation for this is not working post build. |
That sounds good to me |
haoming29
suggested changes
Apr 4, 2024
|
The cache PR causes a bit merge conflict, but after fixing that, we should hold until the login API changes #963 are in |
haoming29
suggested changes
Apr 5, 2024
CannonLock
force-pushed
the
update-login-ui
branch
from
0931c16 to
c4ccb69
Compare
|
@haoming29 Rebased and addressed concerns listed here: #963 (comment) |
|
Note that we still need wait until #963 to be merged in first |
|
@CannonLock We should be good to go, once the branch is rebased/merged against the main and the merge conflicts are fixed |
- Memory Cache User and other information - Remove Jumpiness from various pages that rely on this now cached information - Add a User button - Rework the login page to push towards Oauth login
- pre-commit
Co-authored-by: Haoming Meng <[email protected]>
CannonLock
force-pushed
the
update-login-ui
branch
from
4c74ed7 to
8eec5e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.