Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getNamespaceByPrefix now checks topology for namespace existence #1021

Merged
merged 2 commits into from
Apr 2, 2024
Merged

getNamespaceByPrefix now checks topology for namespace existence #1021

merged 2 commits into from
Apr 2, 2024

Conversation

turetske
Copy link
Collaborator

@turetske turetske commented Apr 1, 2024 

-- Also the namespace struct contains a field determining whether the namespace is from topology

Addresses the first three points in #1005

getNamespaceByPrefix now checks topology for namespace existence
b578141 
	-- Also the namespace struct contains a field determining whether the namespace is from topology
@turetske turetske added this to the v7.7.0 milestone Apr 1, 2024
@turetske turetske requested a review from haoming29 April 1, 2024 19:50
@turetske turetske linked an issue Apr 1, 2024 that may be closed by this pull request
Incompatibility with the topology namespaces and pelican namespaces at the registry #1005
Closed
haoming29
haoming29 previously approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to consider

registry/migrations/20240212192712_create_db_tables.sql Outdated Show resolved Hide resolved
registry/registry_db.go Outdated Show resolved Hide resolved
registry/registry_db.go Show resolved Hide resolved
registry/registry_db.go Show resolved Hide resolved
registry/registry_db.go Outdated Show resolved Hide resolved
registry/registry_db.go Outdated Show resolved Hide resolved
@haoming29
Copy link
Contributor

Sorry I meant to hit Changes Requested

@haoming29 haoming29 dismissed their stale review April 2, 2024 16:02

Hit wrong review result

haoming29
haoming29 suggested changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to consider (see comments above)

@turetske turetske requested a review from haoming29 April 2, 2024 19:20
@turetske turetske force-pushed the fix-namespace-incompatibility branch from 5110dd9 to 1422426 Compare April 2, 2024 20:05
haoming29
haoming29 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@haoming29 haoming29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this

@haoming29 haoming29 merged commit a5e976a into PelicanPlatform:main Apr 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoming29 haoming29 haoming29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.7.0
Development

Successfully merging this pull request may close these issues.

Incompatibility with the topology namespaces and pelican namespaces at the registry
2 participants
@turetske @haoming29