feat:Morpho Blue adaptors #241
Conversation
| morpho_blue_debt_adaptor_v1::Function::BorrowFromMorphoBlue(p) => { | ||
| let market = p.market.unwrap(); | ||
| let market = steward_abi::morpho_blue_debt_adaptor_v1::MarketParams { | ||
| loan_token: sp_call_parse_address(market.loan_token)?, |
There was a problem hiding this comment.
We might be better off defining a single function for converting a MarketParams message from the market input since it's copy-pasted everywhere.
There was a problem hiding this comment.
Yeah I tried this, but unfortunately the ABI bindings each create their own version of it
There was a problem hiding this comment.
Yeah, I guess we could define one per adaptor, and that would cut the copy/paste in half. We still want to avoid the unwraps though I think.
| ) | ||
| } | ||
| morpho_blue_debt_adaptor_v1::Function::BorrowFromMorphoBlue(p) => { | ||
| let market = p.market.unwrap(); |
There was a problem hiding this comment.
We probably shouldn't be calling unwrap and introducing the possibility of a panic. We can have the market params converting function sanity check that the field is present and return an error otherwise, like the other parse functions do.
cbrit
changed the base branch from
collin/new-cellar-2.5-functions
to
3.x-main
No description provided.