Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdc] better manual handling of partitioned tables #2323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heavycrystal
Copy link
Contributor

  1. log when we're remapping child table OID to parent table OID
  2. partition fetching query also allows non-partitioned tables, extensions use this
  3. in case we see an unknown table OID after checking childToParentRelIDMapping, check again to ensure the table wasn't created in the middle of CDC
  4. remove log since it could log PII


if _, ok := p.srcTableIDNameMapping[relID]; !ok {
var parentRelID uint32
err := p.conn.QueryRow(context.Background(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should take ctx parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants