Refactor PCSC Module: Enhance Error Handling and Restart Logic #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor the PCSCWatcher class to improve error handling and restart logic. - Add a maximum limit for the number of start method calls and restart attempts. - Implement delays between restart attempts to prevent excessive resource usage. - Reset the startCalls counter and restartAttempts counter on successful connection.
This update ensures that the pkcs11 module path is validated before iterating over slots. This change prevents duplicate log messages that were previously caused by invalid paths.
This change ensures that the `listen` method is called after setting the event listeners. Previously, some logs triggered during startup were not being recorded in the log.
Kharya1337
approved these changes
Sep 17, 2024
| setTimeout(() => { | ||
| this.start(); | ||
| this._start(); | ||
| }, 1e3); |
There was a problem hiding this comment.
Let's use here PCSCWatcher.START_DELAY as well
Add support for IDPrime 940C and IDPrime 3940B FIDO
|
NPM package v1.10.5 has been published 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the PCSCWatcher by refining error handling and restart mechanisms, boosting stability with PCSC devices. Key updates include:
PCSCWatcher Improvements
console.logstatements.Server Module Updates
CardReaderServiceinLocalServerconstructor when not needed.Script Adjustment
listenruns after setting up event listeners.