Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV-1246: Enable external configuration for all courses #11

Merged
merged 1 commit into from
May 8, 2024

Conversation

kuipumu
Copy link

@kuipumu kuipumu commented Apr 30, 2024

Ticket

https://agile-jira.pearson.com/browse/PADV-1246

Description

This PR enables the use of external configurations on all courses, this is achieved by removing the lti_consumer.enable_external_config_filter waffle flag and all the code related to it, this waffle flag was required per course to enable this feature.

Type of Change

  • Remove the lti_consumer.enable_external_config_filter waffle flag and all it's related code.
  • Update all related unit tests.

Testing

  1. Install and configure xblock-lti-consumer
  2. Create a course and add a LTI 1.3 consumer XBlock.
  3. The XBlock should allow you by default to choose "Reusable Configuration", in the "Configuration Type" field.

Reviewers

@kuipumu kuipumu requested review from anfbermudezme and alexjmpb May 2, 2024 17:39
@alexjmpb
Copy link

alexjmpb commented May 7, 2024

Do you happen to know if there's an error if the waffle flag was already created and then is removed from the code?

@kuipumu
Copy link
Author

kuipumu commented May 8, 2024

Do you happen to know if there's an error if the waffle flag was already created and then is removed from the code?

@alexjmpb I tested this and there is no issue, this waffle flag only changed the values provider of the config_type field and the presentation of such field on studio, the config_type field value is not affected by this change

@kuipumu kuipumu merged commit e84ba38 into pearson-release/olive.main May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants