Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV-1412 - Fix course details link #95

Merged
merged 1 commit into from
Jun 19, 2024
Merged

PADV-1412 - Fix course details link #95

merged 1 commit into from
Jun 19, 2024

Conversation

sergivalero20
Copy link
Contributor

@sergivalero20 sergivalero20 commented Jun 18, 2024

Ticket

https://agile-jira.pearson.com/browse/PADV-1412

Description

This PR fixes malformed url when you go to course details.

Changes made

  • Change masterCourseName by masterCourseId
  • Update tests related

How to test

@01001110J
Copy link
Contributor

In src/features/Licenses/LicenseDetailTable/columns.jsx could be found other incidence:

image

I think that's all, I haven't found other incidences like that. 🤔

@sergivalero20 sergivalero20 force-pushed the vue/PADV-1412 branch 3 times, most recently from 968ca2b to b430732 Compare June 19, 2024 14:09
@sergivalero20 sergivalero20 marked this pull request as ready for review June 19, 2024 14:21
@sergivalero20 sergivalero20 merged commit c5c9311 into master Jun 19, 2024
2 checks passed
@01001110J 01001110J deleted the vue/PADV-1412 branch June 20, 2024 13:36
01001110J added a commit that referenced this pull request Jun 20, 2024
This reverts commit c5c9311, reversing
changes made to 8df2c99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants