Fix: PADV-646 - Default values for first access and last access. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anfbermudezme could you please apply a default value for created column? |
|
@anfbermudezme please mention Created column in Changes made section. |
sergivalero20
approved these changes
Sep 11, 2023
Squirrel18
approved these changes
Sep 14, 2023
anfbermudezme
force-pushed
the
fix/PADV-646
branch
from
69ec0be to
36c825a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fix of the implementation made in https://agile-jira.pearson.com/browse/PADV-646.
Changes made
Screenshots
The error is when the endpoint returns a null value for first access and last_access. The method
Date(row.values.first_access).toUTCString()returns a default Date. For example, as you can see, there are rows with values from the year1970.The desired behavior is that if those values are not there, it does not return anything as shown in the following screenshot:
How to test