PADV-1050 - Integrate Metric Services #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01001110J
reviewed
Mar 5, 2024
| @@ -39,15 +45,15 @@ const StudentsMetrics = () => { | |||
| title="New students registered" | |||
| /> | |||
| <Card.Section> | |||
| <div className="card-number">{stateMetrics.newStudentsRegistered}</div> | |||
| <div className="card-number">{stateStudentsMetrics.numberOfEnrollments}</div> | |||
There was a problem hiding this comment.
Not sure about to use a div for display data, maybe a p or span tag could be more appropriate.
AuraAlba
reviewed
Mar 6, 2024
sergivalero20
force-pushed
the
vue/PADV-1050
branch
from
beba27c to
79b695e
Compare
AuraAlba
approved these changes
Mar 6, 2024
anfbermudezme
requested changes
Mar 6, 2024
| const institution = useSelector((state) => state.main.selectedInstitution); | ||
| const studentsMetrics = useSelector((state) => state.students.studentsMetrics.data); | ||
| const classesMetrics = useSelector((state) => state.students.classesMetrics.data); | ||
| const days = 7; // Temporal variable |
There was a problem hiding this comment.
You have a constant called daysWeek. @sergivalero20
| Next week | ||
| </ToggleButton> | ||
| <ToggleButton id="tbg-radio-3" value={3} variant="outline-primary"> | ||
| <ToggleButton id="tbg-radio-3" value={3} variant="outline-primary" disabled> |
There was a problem hiding this comment.
Same comment. @sergivalero20
There was a problem hiding this comment.
@anfbermudezme It's not possible add inline comments there.
There was a problem hiding this comment.
@sergivalero20 , you could try this
01001110J
approved these changes
Mar 6, 2024
anfbermudezme
approved these changes
Mar 6, 2024
sergivalero20
force-pushed
the
vue/PADV-1050
branch
from
ccc3b62 to
a2925a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-1050
Description
Integrate Metric Services
Changes made
Screenshots
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/students