PADV-731 add institution selector #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfbermudezme
requested changes
Jan 30, 2024
| @@ -11,19 +11,16 @@ import { fetchCoursesData } from 'features/Courses/data/thunks'; | |||
| import { initialPage } from 'features/constants'; | |||
|
|
|||
| const CoursesPage = () => { | |||
| const stateInstitution = useSelector((state) => state.main.institution.data); | |||
| const institutionSelected = useSelector((state) => state.main.institutionSelected); | |||
There was a problem hiding this comment.
Suggested change
| const institutionSelected = useSelector((state) => state.main.institutionSelected); | |
| const selectedInstitution = useSelector((state) => state.main.selectedInstitution); |
Could you please change the name of this variable in all modules? @AuraAlba
AuraAlba
force-pushed
the
vue/PADV-731
branch
from
56e5c04 to
74e6c5a
Compare
AuraAlba
force-pushed
the
vue/PADV-731
branch
from
74e6c5a to
827ace3
Compare
anfbermudezme
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-731
Description
Add institution selector
Changes made
Add institution selector
Update files where institution id is necessary
Update services missing institution id
Update test
Screenshots
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/dashboard