Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV-949 Add licenses page #29

Merged
merged 2 commits into from
Jan 17, 2024
Merged

PADV-949 Add licenses page #29

merged 2 commits into from
Jan 17, 2024

Conversation

AuraAlba
Copy link
Contributor

Ticket

https://agile-jira.pearson.com/browse/PADV-949

Description

Add license table and licenses page

Changes made

Add licenses page component
Add licenses in navbar
Add data to store redux
Move active tab to store
Update tests

Screenshots

Screenshot from 2024-01-16 13-13-55

How to test

Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/licenses

@AuraAlba AuraAlba requested a review from Squirrel18 January 16, 2024 18:15
const [currentPage, setCurrentPage] = useState(initialPage);

let idInstitution = '';
if (stateInstitution.length > 0) { idInstitution = stateInstitution[0].id; }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use ternary operator. @AuraAlba

/>
)}
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary blank line. @AuraAlba

@AuraAlba AuraAlba merged commit d6dbb65 into master Jan 17, 2024
2 checks passed
@AuraAlba AuraAlba deleted the vue/PADV-949 branch January 17, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants