PADV-894 Add license table in home page #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squirrel18
requested changes
Jan 15, 2024
| const [dataTableLicense, setDataTableLicense] = useState([]); | ||
|
|
||
| let idInstitution = ''; | ||
| if (stateInstitution.length > 0) { idInstitution = stateInstitution[0].id; } |
There was a problem hiding this comment.
I think you can use ternary operator to avoid the if statement. @AuraAlba
There was a problem hiding this comment.
I changed it. This is a temporary implementation, when the institution selector is implemented this will be removed
Comment on lines
23
to
33
| if (licenseData.length > 5) { | ||
| const arraySorted = licenseData.slice().sort((license1, license2) => { | ||
| if (license1.numberOfPendingStudents > license2.numberOfPendingStudents) { return 1; } | ||
| if (license1.numberOfPendingStudents < license2.numberOfPendingStudents) { return -1; } | ||
| return 0; | ||
| }); | ||
| setDataTableLicense(arraySorted.slice(0, 5)); | ||
| } else { setDataTableLicense(licenseData); } | ||
| }, [licenseData]); |
There was a problem hiding this comment.
What's the purpose of this? @AuraAlba
There was a problem hiding this comment.
It return 5 licenses with fewest remaining seats, in home it's only necessary to show these licenses. In the license page will be shown all
AuraAlba
force-pushed
the
vue/APDV-894
branch
from
1e31ef9 to
9641c5c
Compare
Squirrel18
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-894
Description
Add license table in home page
Changes made
Add license table component
Add data to store redux
Update tests
Screenshots
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/dashboard