PADV-944 Add redux in students and courses pages #27
Conversation
| numPages: 0, | ||
| count: 0, | ||
| }, | ||
| courses: { |
There was a problem hiding this comment.
courses, classes and filters have the same initialState, is there some way to unify it? @AuraAlba
There was a problem hiding this comment.
I created a constat and import it in the states with the same structure
src/features/Students/data/slice.js
Outdated
| status: RequestStatus.LOADING, | ||
| error: null, | ||
| }, | ||
| filters: {}, |
There was a problem hiding this comment.
Could you please move this to the end of the inititalState. @AuraAlba
| <StudentsTable data={data} count={data.length} columns={getColumns()} />, | ||
| <Provider store={store}> | ||
| <StudentsTable data={data} count={data.length} columns={getColumns()} /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| // Check if the table rows are present |
There was a problem hiding this comment.
Is this inline comment necessary? @AuraAlba
There was a problem hiding this comment.
Not. I removed them
| @@ -43,7 +43,9 @@ const InstructorsFilters = ({ resetPagination }) => { | |||
| const formJson = Object.fromEntries(formData.entries()); | |||
| dispatch(updateFilters(formJson)); | |||
| try { | |||
| dispatch(fetchInstructorsData(currentPage, formJson)); | |||
| const initialPage = 1; | |||
There was a problem hiding this comment.
What do you think about having a module dedicated to constants? @AuraAlba
There was a problem hiding this comment.
We already have a constants file, so I moved it there
|
|
||
| const CoursesPage = () => { | ||
| const stateInstitution = useSelector((state) => state.main.institution.data); | ||
| const [state, dispatch] = useReducer(reducer, initialState); | ||
| const stateCourses = useSelector((state) => state.courses); | ||
| const dispatch = useDispatch(); | ||
| const [currentPage, setCurrentPage] = useState(1); |
There was a problem hiding this comment.
| const [currentPage, setCurrentPage] = useState(1); | |
| const [currentPage, setCurrentPage] = useState(initialPage); |
| const CoursesFilters = ({ | ||
| fetchData, resetPagination, dataCourses, setFilters, | ||
| resetPagination, |
There was a problem hiding this comment.
| resetPagination, | |
| const CoursesFilters = ({ resetPagination }) => { |
| dataCourses={dataCourses} | ||
| />, | ||
| <Provider store={store}> | ||
| <CoursesFilters |
There was a problem hiding this comment.
| <CoursesFilters | |
| <CoursesFilters resetPagination={resetPagination} /> |
| dataCourses={dataCourses} | ||
| />, | ||
| <Provider store={store}> | ||
| <CoursesFilters |
There was a problem hiding this comment.
| <CoursesFilters | |
| <CoursesFilters resetPagination={resetPagination} /> |
Ticket
https://agile-jira.pearson.com/browse/PADV-944
Description
Manage unique state with redux to shared state between components
Changes made
Define redux actions and reducer for couses and students pages
Import redux store in other pages
Add and update tests
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/