fix: change src image to configuration #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anfbermudezme
requested changes
Dec 27, 2023
src/features/Main/Header/index.jsx
Outdated
| @@ -13,7 +13,7 @@ export const Header = () => { | |||
| <header className="institution-header py-4 px-3"> | |||
| <div className="header-left d-flex"> | |||
| <a href={`${getConfig().LMS_BASE_URL}`}> | |||
| <img src="/images/logoPearson.png" alt="icon" /> | |||
| <img src={`${getConfig().LOGO_URL_INSTITUTION}`} alt="icon" /> | |||
There was a problem hiding this comment.
What do you think?
Suggested change
| <img src={`${getConfig().LOGO_URL_INSTITUTION}`} alt="icon" /> | |
| <img src={`${getConfig().LOGO_INSTITUTION_PORTAL}`} alt="icon" /> |
AuraAlba
force-pushed
the
fix/PADV-903
branch
from
3eff08e to
468ad14
Compare
anfbermudezme
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-903
Description
Change scr logo to get from configurations
Changes made
Change src logo
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/