PADV-903 feat: changes footer and header #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuraAlba
force-pushed
the
vue/PADV-903
branch
from
7b90686 to
ee9bd7a
Compare
|
@AuraAlba What do you think about put Search title outside the box of the filters.
|
|
@AuraAlba Footer should have the same background color as the sidebar. |
Squirrel18
requested changes
Dec 21, 2023
src/features/Main/Header/index.jsx
Outdated
Comment on lines
25
to
29
| <a href="/"> | ||
| <span className="icon"> | ||
| <FontAwesomeIcon icon={faEarthAmericas} /> | ||
| </span> | ||
| </a> |
There was a problem hiding this comment.
What's the purpose of this? @AuraAlba
There was a problem hiding this comment.
I added the links from the site configuration
AuraAlba
force-pushed
the
vue/PADV-903
branch
3 times, most recently
from
39791f5 to
25957e3
Compare
AuraAlba
force-pushed
the
vue/PADV-903
branch
from
25957e3 to
1a7959f
Compare
Squirrel18
approved these changes
Dec 22, 2023
anfbermudezme
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-903
Description
Change footer, header and sidebar according to new design
Changes made
Change footer, header, sidebar styles
Adjust title for students, instructors and courses pages
Add fontawesome pro stylesheet
Update tests
Screenshots
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/insructors