PADV-1927 feat: add page size param to services #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01001110J
reviewed
Dec 27, 2024
Comment on lines
53
to
62
| {isLoadingClasses && ( | ||
| <div className="w-100 h-100 d-flex justify-content-center align-items-center"> | ||
| <Spinner | ||
| animation="border" | ||
| className="mie-3" | ||
| screenReaderText="loading" | ||
| /> | ||
| </div> | ||
| )} | ||
| {!isLoadingClasses && classCards.map(classInfo => <ClassCard data={classInfo} key={classInfo?.classId} />)} |
There was a problem hiding this comment.
Great addition, but I would like to suggest that changes outside the scope of the issue should go into a separate PR. This way, changes won't get mixed, and it will make the review process easier by avoiding unrelated updates to the issue's scope. Additionally, if a revert is needed, it would only affect a specific change rather than multiple changes at once.
AuraAlba
force-pushed
the
vue/PADV-1927
branch
from
68f7ce7 to
d23a99a
Compare
Same as instructors portal, we don't need pages in this component and we already implement a function to call all pages, so we don't change to avoid performance issues |
01001110J
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-1927
Description
add page size param to services
Changes made
Add page size param to services, to get max 200 records
Add spinner loaders where is missing
Update test
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/institution-portal