refactor: sort institution select alphabetically #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01001110J
reviewed
Dec 27, 2024
There was a problem hiding this comment.
I recommend performing the sorting in the thunk. This ensures that the institutions are stored in a sorted order in the store, making them readily usable in different contexts, not just for this selector.
There was a problem hiding this comment.
@01001110J, thanks, and sorry for this. I already applied the change
bra-i-am
force-pushed
the
vue/PADV-1159
branch
2 times, most recently
from
34c4c49 to
b628c36
Compare
01001110J
approved these changes
Dec 27, 2024
AuraAlba
approved these changes
Dec 27, 2024
|
Don't forget to rebase master |
bra-i-am
force-pushed
the
vue/PADV-1159
branch
from
b628c36 to
261611a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
PADV-1159
Description
This PR modifies the institution selector so this is sorted alphabetically
Screenshots