feat: event modal #140
Closed
feat: event modal #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01001110J
force-pushed
the
vue/PADV-1760
branch
from
839902d to
0cac229
Compare
01001110J
force-pushed
the
vue/PADV-1761
branch
from
c130db5 to
764b8d5
Compare
01001110J
force-pushed
the
vue/PADV-1761
branch
from
764b8d5 to
499353c
Compare
01001110J
force-pushed
the
vue/PADV-1760
branch
from
0cac229 to
ca585df
Compare
01001110J
force-pushed
the
vue/PADV-1761
branch
from
499353c to
8d11d26
Compare
AuraAlba
requested changes
Dec 23, 2024
There was a problem hiding this comment.
If a create an event and then change a page, in the get events I don't see the new event I created, did you mention that to Cesar?
There was a problem hiding this comment.
Can you provide a video or something for this, I did not have this issue:
2024-12-23.09-50-04.mp4
|
Functionality no longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the modal to add a new event.
Rresolves PADV-1761
Visual results
Before
After
How to test
Configure the flag
enable_instructor_calendarin the site admin 18000 or override the content of the requesthttp://localhost:18000/api/mfe_config/to have the flag intrueGo to '/instructors/:instructorUsername' if
enable_instructor_calendaristrueyou should be able to see the calendar along with theevents/request, if the flag isfalseyou shouldn't see any of both.