PADV-726 call service for add instructor #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuraAlba
changed the title
AuraAlba
force-pushed
the
vue/PADV-726
branch
from
8521f47 to
dd8ac99
Compare
AuraAlba
commented
Oct 24, 2023
| @@ -39,20 +34,26 @@ const AddInstructors = () => { | |||
| } | |||
| }; | |||
|
|
|||
| const handleInstructorInput = (e) => { | |||
There was a problem hiding this comment.
@Squirrel18 @anfbermudezme I changed the components form controlled to uncontrolled so when submit the form I will get the values and don't have the problem with the select
anfbermudezme
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://agile-jira.pearson.com/browse/PADV-726
Description
Call service add instructors
Changes made
Add service to modify access for instructor
Handle error when user does not exist
Add default value for select ccx for bug component
Add tests
Screenshots
How to test
Clone the Institution Portal MFE
Run npm install.
Run npm run start
Go to http://localhost:1980/instructors