Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: availability tab with calendar #139

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat: availability tab with calendar #139

merged 1 commit into from
Dec 19, 2024

Conversation

01001110J
Copy link
Contributor

@01001110J 01001110J commented Dec 17, 2024

Description

This PR adds a new tab Availability in instructor detail page along with a calendar with its events.

This PR resolves PADV-1760

Change log

  • Renamed test folder in instructors detail page and data folder to use double _ instead a single _
  • Re factorization in useEffect, spitted responsibilities and added clean methods for classes and events
  • Added flag enable_instructor_calendar to show the calendar along with its events
  • Updated unit test

Visual results

Before

before

After

after

How to test

  • Configure the flag enable_instructor_calendar in the site admin 18000 or override the content of the request http://localhost:18000/api/mfe_config/ to have the flag in true

  • Go to '/instructors/:instructorUsername' if enable_instructor_calendar is true you should be able to see the calendar along with the events/ request, if the flag is false you shouldn't see any of both.

@01001110J 01001110J self-assigned this Dec 17, 2024
@01001110J 01001110J requested review from sergivalero20 and AuraAlba and removed request for sergivalero20 December 17, 2024 22:52
@01001110J 01001110J marked this pull request as ready for review December 17, 2024 23:10
@01001110J 01001110J merged commit d2b3433 into master Dec 19, 2024
2 checks passed
@01001110J 01001110J deleted the vue/PADV-1760 branch December 19, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants