Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PADV-1892 - Classes page and Course Details page are now working correctly. #135

Merged
merged 1 commit into from
Dec 9, 2024
Merged

PADV-1892 - Classes page and Course Details page are now working correctly. #135

merged 1 commit into from
Dec 9, 2024

Conversation

sergivalero20
Copy link
Contributor

@sergivalero20 sergivalero20 commented Dec 5, 2024 •
edited
Loading

Ticket

https://agile-jira.pearson.com/browse/PADV-1892

Description

This PR solves two errors which are occurring in Classes and /Courses/Classes.

  1. Classes page: When page is reloaded then all classes are shown and it should be filtered by institution.
  2. Courses detail page: Course info is disappearing when page is reloaded.

Changes made

  • Classes page
  • Courses details page

How to test

  • Clone the Institution Portal MFE
  • Run npm install
  • Run npm run start
  • Go to /classes and reload page to make sure everything is working as expected.
  • Go to /Courses/Classes and reload page to make sure everything is working as expected. Course info should be displayed correctly.

@sergivalero20 sergivalero20 force-pushed the vue/PADV-1892 branch 2 times, most recently from 67dc0e8 to 2b25709 Compare December 5, 2024 19:34
01001110J
01001110J reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@01001110J 01001110J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm not understanding exactly what's going on here, so how can I reproduce the error/s?

Can you provide a better description of the before and after?

src/features/Classes/ClassesPage/index.jsx Show resolved Hide resolved
AuraAlba
AuraAlba requested changes Dec 6, 2024
View reviewed changes
src/features/Courses/CoursesDetailPage/index.jsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this page I get two calls to courses services, I don't know why is that necessary, check if you can remove one of them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AuraAlba change applied!

@sergivalero20 sergivalero20 merged commit 5fda844 into master Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@01001110J 01001110J 01001110J approved these changes

@AuraAlba AuraAlba AuraAlba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergivalero20 @AuraAlba @01001110J