Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display search on course filter #133

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: display search on course filter #133

merged 1 commit into from
Dec 3, 2024

Conversation

01001110J
Copy link
Contributor

@01001110J 01001110J commented Nov 29, 2024 •
edited
Loading

Description

This PR resolves PADV-1882 now the filter shows the search made

Change log

  • Updated CourseFilters to show the search maded.

Visual results

Before

certprepcourseware-staging pearson com_certprep-manager_courses_institutionId=3

After

localhost_1980_institution-portal_courses_institutionId=1

How to test

Clone the Portal MFE

     git clone <url>

Install the packages 📦.

     npm i

Start project.

     npm start

Finally, go to courses/ and test the results.

@01001110J 01001110J requested a review from AuraAlba November 29, 2024 22:31
@01001110J 01001110J self-assigned this Nov 29, 2024
@01001110J 01001110J marked this pull request as ready for review November 29, 2024 22:34
@01001110J 01001110J merged commit dfccf17 into master Dec 3, 2024
2 checks passed
@01001110J 01001110J deleted the vue/PADV-1882 branch December 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergivalero20 sergivalero20 sergivalero20 approved these changes

@AuraAlba AuraAlba AuraAlba approved these changes

Assignees

@01001110J 01001110J

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@01001110J @AuraAlba @sergivalero20