Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV-1554 - Change course/class title by a unique identifier (course_id/class_id) #112

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

sergivalero20
Copy link
Contributor

@sergivalero20 sergivalero20 commented Aug 14, 2024

Ticket

https://agile-jira.pearson.com/browse/PADV-1554
https://agile-jira.pearson.com/browse/PADV-1562

Description

In order to solve an issue reporting by Scott, witch is causing that classes and courses are not filtered correctly. We decided to change in the URL and in the service calls class/course title by key because it's a unique identifier (PADV-1554).

In the other hand, message when an Instructor is added to a class was modified (PADV-1562).

Changes made

  • Dashboard View
  • Classes View
  • Courses View
  • Instructors View

How to test

  • Clone the Institution Portal MFE
  • Run npm install
  • Run npm run start
  • Go to http://localhost:1980/institution-portal/
  • Test all features in Dashboard View (e.g. Weekly Schedule)
  • Test all features in Classes View (e.g. student enrollment)
  • Test all features in Courses View (e.g. Classes creation)
  • Test all features in Instructors View (e.g. Instructors assignment)

@sergivalero20 sergivalero20 marked this pull request as ready for review August 15, 2024 20:19
@sergivalero20 sergivalero20 changed the title PADV-1554 - Change course/class title by key PADV-1554 - Change course/class title by a unique identifier (course_id/class_id) Aug 15, 2024
@sergivalero20 sergivalero20 force-pushed the vue/PADV-1554 branch 2 times, most recently from 41a9526 to 5ff3bf7 Compare August 16, 2024 15:52
@sergivalero20 sergivalero20 merged commit 80ad2cb into master Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants