Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial config, is missing fix the update on reload #107

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

01001110J
Copy link
Contributor

@01001110J 01001110J commented Jul 15, 2024

Ticket

https://agile-jira.pearson.com/browse/PADV-1414

Description

In this PR is fixed the error at the moment to open a new tab, the reference of the institution is lost.

Changes made

  • Refactor in the selector, is been moved to a different file, is included the respective test.
  • Added new custom hook to handle the query param using the redux context.
  • Refactor in ALL application links to reflect the institution selected.
  • Added new dep to help at the moment to test a custom hook.
  • Refactor to the function resposable to format the select option along with it test.

Screenshot

image

How to test

  • Make sure to have the devstack runnint
  • Instal deps @testing-library/react-hooks has been added.
  npm i 
  • Go to http://localhost:1980/
  • The URL must change automatically to reflect the current institution id.
    -- If you have multiple institutions, change it using the selector, then copy the new url, you should be able to recover the institution selected in the previous tab, along with it information.

@01001110J 01001110J self-assigned this Jul 18, 2024
@01001110J 01001110J marked this pull request as ready for review July 18, 2024 18:09
src/features/Main/InstitutionSelector/index.jsx Outdated Show resolved Hide resolved
src/features/Main/index.jsx Outdated Show resolved Hide resolved
@01001110J 01001110J requested a review from AuraAlba July 22, 2024 16:16
@01001110J 01001110J merged commit 872170c into master Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants