Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Missed camelCase calls in StudentTable. #10

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix - Missed camelCase calls in StudentTable. #10

merged 1 commit into from
Sep 27, 2023

Conversation

anfbermudezme
Copy link
Contributor

@anfbermudezme anfbermudezme commented Sep 26, 2023 •
edited
Loading

Description

In accordance with the Minimum Viable Product (MVP) we need to Revoke pending enrollments using the MFE. The fix implemented in #9 change the way to access to the keys, now using CamelCase. For enrollmentData used for the handleEnrollments API call the respective change was not made.

Changes Made

  • Change key to CamelCase in enrollmentData in StudentsTable.
  • Change key of ccxId to hide column in StudentsTable.

How to test

  • Up openedx services (including Course Operations)
  • Run npm install
  • Run npm start
  • Go to http://localhost:1980/
  • Go to StudentsPage and revoke pending enrollment.

@anfbermudezme anfbermudezme merged commit 238596a into master Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergivalero20 sergivalero20 sergivalero20 approved these changes

@Squirrel18 Squirrel18 Squirrel18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anfbermudezme @Squirrel18 @sergivalero20