chore: address comments

Pearson-Advance · Dec 12, 2024 · ebe2edd · ebe2edd
1 parent 30ca6db
commit ebe2edd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/src/features/Dashboard/data/_test_/redux.test.jsx b/src/features/Dashboard/data/_test_/redux.test.jsx
@@ -29,7 +29,7 @@ describe('Dashboard redux tests', () => {
 
   test('successful fetch licenses data', async () => {
     const licensesApiUrl = `${process.env.COURSE_OPERATIONS_API_V2_BASE_URL}/license-pool`
-    + '/?limit=false&institution_id=1&page=1&';
+    + '/?limit=false&institution_id=1';
     const mockResponse = [
       {
         licenseName: 'License Name 1',

diff --git a/src/features/Licenses/LicensesPage/index.jsx b/src/features/Licenses/LicensesPage/index.jsx
@@ -28,10 +28,8 @@ const LicensesPage = () => {
       dispatch(fetchLicensesData(selectedInstitution?.id, currentPage, stateLicenses.filters));
     }
 
-    return () => {
-      dispatch(resetLicensesTable());
-    };
-  }, [selectedInstitution, dispatch, currentPage]);
+    return () => dispatch(resetLicensesTable());
+  }, [selectedInstitution, dispatch, currentPage]); // eslint-disable-line react-hooks/exhaustive-deps
 
   return (
     <Container size="xl" className="px-4">

diff --git a/src/features/Licenses/data/_test_/redux.test.jsx b/src/features/Licenses/data/_test_/redux.test.jsx
@@ -30,7 +30,7 @@ describe('Licenses redux tests', () => {
 
   test('successful fetch licenses data', async () => {
     const licensesApiUrl = `${process.env.COURSE_OPERATIONS_API_V2_BASE_URL}/license-pool`
-    + '/?limit=true&institution_id=1&page=1&';
+    + '/?limit=true&institution_id=1';
     const mockResponse = {
       results: [
         {
@@ -67,7 +67,7 @@ describe('Licenses redux tests', () => {
 
   test('failed fetch licenses data', async () => {
     const licensesApiUrl = `${process.env.COURSE_OPERATIONS_API_V2_BASE_URL}/license-pool`
-    + '/?limit=false&institution_id=1&page=1&';
+    + '/?limit=false&institution_id=1';
     axiosMock.onGet(licensesApiUrl)
       .reply(500);