Skip to content

Commit

Permalink
fix: typos and trailing comma
Browse files Browse the repository at this point in the history
  • Loading branch information
Nekenhei committed Nov 18, 2024
1 parent 66e03d6 commit 33288c0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions docs/001-custom-features.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ This feature allows CCX coaches (ccx_coach in the course access role model) and
### Context

The SGA Xblock in its upstream repository approaches the storage capability by relaying on the Django's default storage
that is defined in the edx platform. Tehre's also a feature where the storage backend to be used can be defined via
that is defined in the edx platform. There's also a feature where the storage backend to be used can be defined via
platform settings. For our fork, this feature adds the capability to define a site-aware backend via site configurations.

### Feature

To define a desire backend shall follow the following format by defining the storage class and it's kwargs.
To define a d backend shall follow the following format by defining the storage class and its kwargs.
As an example, below you will be find de Site Configuration definition to use an AWS S3 bucket:

"SGA_STORAGE_SETTINGS": {
Expand All @@ -56,4 +56,4 @@ As an example, below you will be find de Site Configuration definition to use an
}

Once it has been done, the SGA xblocks for the given site will manage the media objects with the defined storage backend.
If no settings are defined, the Xblock would use the default Django storage
If no settings are defined, the Xblock will use the default Django storage
2 changes: 1 addition & 1 deletion edx_sga/tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_get_default_storage_with_settings_override(mock_configuration_helpers):
"region_name": "us-east-1"
}
}
}
},
)
storage = get_default_storage()
assert storage.__class__ == S3Boto3Storage
Expand Down

0 comments on commit 33288c0

Please sign in to comment.